Azure / packer-azure

Packer for Azure
MIT License
115 stars 50 forks source link

Empty Artifact returned by azure-arm builder #220

Closed arsenvlad closed 8 years ago

arsenvlad commented 8 years ago

packerscreenshot1

Currently, the URL of the captured image is not returned as part of the artifact.

paulmey commented 8 years ago

Yup. Any other info you'd like in there? (so that we can design it right in one go)

arsenvlad commented 8 years ago

AWS returns: Amis, BuilderIdValue, EC2 Conn Digital Ocean returns: Snapshot Name, Snapshot ID, Region Name, Client Google returns: Image Name, Driver OpenStack returns: ImageId, BuilderIdValue, Client File returns: Filename Docker returns: IdValue, BuilderIdValue, Driver

For Azure, it would be convenient to have access to the following types of fields: • Captured Disk Storage Account Location • Captured Disk Storage Account Name • Captured Disk Storage Account Container • Captured Disk Blob Name • Captured Disk Full URI • Captured Disk Full URI with SAS read access (for X days) • Captured VM JSON template (if any is generated during capture process) for easier recreation of the VM

Will the capture ever have more than 1 disk?

paulmey commented 8 years ago

Thanks for that list. The capture currently has only one disk because the default template that we use has only one disk. I'd say there could be more than one, since I would not want to exclude using custom templates at some point in the future. So then we'll have a list of disks and the JSON template?

arsenvlad commented 8 years ago

For multi-disk captures (where there is one OS Disk and multiple Data Disks) the artifact would need to include the list of disks with a type designating which one is the OS, which are the data disks, and their LUNs.

boumenot commented 8 years ago

Fixed with PR #236.

The artifact outputs the following data.

We removed storage account name, blob, and container because they can be determined by the URI.

We do not handle the case of multi-disk captures. I will open a new issue to track this.