search

Azure / partnercenter-cli-extension

Partner Center Azure CLI Extension
MIT License
12 stars 11 forks source link

feat: Add parameter for Managed App subtype #185

Closed dciborow closed 1 year ago

dciborow commented 1 year ago

Description

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, edit the PR description and run through the relevant checklist below.

image

This also fixes an issue when running 'az partnercenter marketplace offer plan update', by first checking if 'externalID' is in variant. https://github.com/dciborow/partnercenter-cli-extension/blob/dc3a9592f2b853ea5f7c5e69b8e47d0ef47d916d/partnercenter/azext_partnercenter/clients/plan_client.py#L57:L66

dciborow commented 1 year ago

not ready for review or merge - stilll in progress but putting it up as PR for visability

dciborow commented 1 year ago

Ready for review. This adds the subtype parameter, and also fixes a bug. Before making more modifications, think it's time to review and merge these changes.