Azure / pcs-cli

A CLI for deploying Azure IoT PCS

MIT License

33 stars 37 forks source link

Add new environment variables for diagnostic service #332

Closed zhang-hua closed 6 years ago

zhang-hua commented 6 years ago

Description and Motivation

...

Change type

[ ] Bug fix
[x] New feature
[ ] Enhancement
[ ] Breaking change (breaks backward compatibility)

Checklist:

[x] All tests passed
[x] The code follows the code style and conventions of this project
[x] The change requires a change to the documentation
[ ] I have updated the documentation accordingly

This change is

zhang-hua commented 6 years ago

Will rebase code with master branch after PR #331 was merged.

molly-moen commented 6 years ago

I forgot we also need to add PCS_SOLUTION_NAME as a variable (I thought it was added but it is still in PR from the interns: https://github.com/Azure/pcs-cli/pull/321/files), and send it to the diagnostics service

ppathan commented 6 years ago

@zhang-hua Can you resolve the conflicts?