Azure / pcs-cli

A CLI for deploying Azure IoT PCS

MIT License

33 stars 37 forks source link

Don't output commands with credentials from setup.sh script to console #406

Closed zadixon closed 5 years ago

zadixon commented 6 years ago

Type of issue

[x] Bug
[ ] New feature
[ ] Enhancement

Description

Don't output commands with credentials from setup.sh script to console. When the vm extension deployment fails, these are logged, meaning that secrets can be exposed.

Steps to reproduce

Expected behavior

...

Current behavior <!-- The actual behavior observed --

...

Known workarounds

...

Possible solution

...

Context and Environment

Operating System: ...
GitHub branch: ...
Node.js Runtime: ...

zhang-hua commented 6 years ago

The error message was saved into: /var/lib/waagent/custom-script/download/1/stderr

ashdonaldson14 commented 6 years ago

408 Need to do the same here.

zhang-hua commented 5 years ago

PR https://github.com/Azure/pcs-cli/pull/427 pushed by @ sakimsft to fix this issue.

zhang-hua commented 5 years ago

Close it since PR has been merged.