Azure / pcs-cli

A CLI for deploying Azure IoT PCS

MIT License

33 stars 37 forks source link

cli script hangs #414

Closed JetstreamRoySprowl closed 5 years ago

JetstreamRoySprowl commented 5 years ago

Type of issue

[x] Bug

Description

On my main (and brand new) computer, when I run pcs -t remotemonitoring -s basic -r dotnet the script accepts my solution name and my subscription choice, but it then hangs indefinitely after it accepts the subscription. No further keystrokes are responded to at all. I have to close the command window to get rid of it.

I do not have this problem creating the same solution on one of my other machines (with a whole bunch of other npm packaged installed).

I've included a file showing the session. It shows a fresh npm install -g iot-solutions output followed by the problematic login/command sequence. pcs session.txt

Context and Environment

Operating System: Windows 10 pro 64 Version 10.0.17134.345
GitHub branch: N/A
Node.js Runtime: v10.13.0 (64 bit)

JetstreamRoySprowl commented 5 years ago

This hanging behavior continues in the recent 2.0.0 commit. I've discovered that the failure happens with nodejs version 10.13.0 but not with nodejs version 8.3.0

ppathan commented 5 years ago

I have tried it with 10.13 node version and I'm able to run the command without issues. The latest released version for CLI is 1.0.13. Can you try again?

JetstreamRoySprowl commented 5 years ago

I did try again; on my older box which was able to run successfully using the npm published iot-solutions, I was able to reproduce this failure by upgrading to node 10.13.0 with no other changes. That makes two machines to repro the problem.

ppathan commented 5 years ago

Also reported by #431

ppathan commented 5 years ago

Not sure what you mean, this issue is still open. I closed the other issue.

toddwhitehead commented 5 years ago

I get same issue with node 10.13.0

sakimsft commented 5 years ago

The cause is identified and the fix is on the way.

akn9050 commented 5 years ago

Is it fixed. If not, what is expected time.

elvinm commented 5 years ago

Yes this has been fixed here https://github.com/Azure/pcs-cli/pull/438 though we haven't published a newer version of the package yet. If you are building the packages locally (npm install & npm start & npm link) then you can just grab the latest code from master.

If not, please let me know and I'll find what our timeline is on getting an update pushed out.

avneet723 commented 5 years ago

Will be in the next release.