Closed dluc closed 5 years ago
Scripts tested and working fine. The only issue I noticed is a missing "testing" tag in the docker-compose when deploying the branch with CLI, unrelated to this PR
@ppathan yes, these 2 PRs contain improvements/fixes that we should apply to other solutions:
setup-wrapper.sh
and change it to point to the relevant GitHub URL, note how it doesn't use set -ex
to avoid leaking secretssetup-wrapper.sh
(instead of setup.sh
) and use bash
instead of sh
setup.sh
take the retry logic used to install Docker and other minor improvements about error detectionNote that the setup now creates a log file under /app
Description and Motivation
Change type
Checklist:
This change is