Azure / pcs-cli

A CLI for deploying Azure IoT PCS
MIT License
33 stars 37 forks source link

The 'vault.azure.net' suffix is not available in Azure China #525

Closed lzyms closed 3 years ago

lzyms commented 5 years ago

Type of issue

Description

In the 3.0.0 version, the auth.sh file use the 'https://$PCS_KEYVAULT_NAME.vault.azure.net' to do some settings, and some microservices use 'private const string KEY_VAULT_URI = "https://{0}.vault.azure.net/secrets/{1}";' to get secret from Azure Keyvault, but the 'vault.azure.net' suffix is not available in Mooncake, should replace it by 'vault.azure.cn'.

Steps to reproduce

  1. pcs login -e AzureChinaCloud
  2. pcs -t remotemonitoring -s basic
  3. Do some workarounds to make the Azure resources deploy succeed

Expected behavior

Deploy succeed and all microservices work

Current behavior <!-- The actual behavior observed --

Microservices cannot work

Known workarounds

n/a

Possible solution

Use 'vault.azure.cn' in Azure China

Context and Environment

• Operating System: Win10 1903 • GitHub branch: 51dacd2aa4 • Node.js Runtime: v10.16.0