Azure / pcs-remote-monitoring-webui

Azure IoT PCS Remote Monitoring Web UI
MIT License
54 stars 72 forks source link

Repo forks of external developers are not getting built in VSTS #1128

Closed isaac-dasan closed 6 years ago

isaac-dasan commented 6 years ago

Type of issue

Description

https://github.com/Azure/pcs-remote-monitoring-webui/pull/1123

The above PR did not get a build even after 3 days. After a brief investigation, I found that the branch is from a different fork in Github account. Our repo -> https://github.com/Azure Actual repo where is branch is at -> https://github.com/dominicbetts

To mitigate, I manually triggered a build in VSTS referencing the PR number. https://solutionaccelerators.visualstudio.com/RemoteMonitoring/RemoteMonitoring%20Team/_build/results?buildId=1809

I guess this issue could have sneaked in when we migrated from travis to VSTS.

ashdonaldson14 commented 6 years ago

@sushilraje Will look into this.

sushilraje commented 6 years ago

@isaac73: This is a feature we have disabled on all of our builds. To enable - you can go to Build → Triggers, Under triggers, Enable Pull Request → Enable builds on Fork

Its not recommended though due to reasons mentioned here.

For you current build of webui, I have activated the build from fork, please disable it once you are done.