Closed ionutleca closed 3 years ago
@nishubansal @N-Usha this is a much needed feature for this Action. Can we get this reviewed and merged in once the node_modules/
dir is removed from this PR?
@ionutleca is there any progress on the PR ? This feature would be very usefull
So it looks like this PR is stuck in limbo. Is there some other way of getting this functionality into here? Being able to set the values of pipeline variables is really important. Can the core team just implement the functionality without using this PR? Or can I submit a PR with a similar code to get this moving?
I will try to get my current employer approval for the CLA required for this PR. If I find out that it takes more than 24h, I'll let you know if you should just create the PR with these changes yourself, @mfcollins3.
Thanks, @ionutleca. I greatly appreciate you getting the CLA approved. I can't wait to start using this!
@ionutleca I'm assuming since 24h turned into 2+ months, one of us can go ahead and create the PR with these changes ourselves?
The CLA was approved a long time ago.
Apologies, the timeline was a bit confusing. It’s a shame because this is super useful, but they seemed to let it fall by the wayside.
No worries. It seems useful to me as well, but we might be the only ones :))
@nishubansal @N-Usha @anweiss Can anyone finally get this merged in?
Any chance either this or the PR for adding build parameters might get merged in?
+1 to getting this merged in
All CLA requirements met.