Azure / pipelines

Enable GitHub developers to trigger Azure Pipelines from a GitHub Actions workflow
MIT License
73 stars 83 forks source link

Feature/add pipeline variables #11

Closed ionutleca closed 3 years ago

msftclas commented 4 years ago

CLA assistant check
All CLA requirements met.

anweiss commented 4 years ago

@nishubansal @N-Usha this is a much needed feature for this Action. Can we get this reviewed and merged in once the node_modules/ dir is removed from this PR?

msoute commented 4 years ago

@ionutleca is there any progress on the PR ? This feature would be very usefull

mfcollins3 commented 4 years ago

So it looks like this PR is stuck in limbo. Is there some other way of getting this functionality into here? Being able to set the values of pipeline variables is really important. Can the core team just implement the functionality without using this PR? Or can I submit a PR with a similar code to get this moving?

ionutleca commented 4 years ago

I will try to get my current employer approval for the CLA required for this PR. If I find out that it takes more than 24h, I'll let you know if you should just create the PR with these changes yourself, @mfcollins3.

mfcollins3 commented 4 years ago

Thanks, @ionutleca. I greatly appreciate you getting the CLA approved. I can't wait to start using this!

FlipABit commented 3 years ago

@ionutleca I'm assuming since 24h turned into 2+ months, one of us can go ahead and create the PR with these changes ourselves?

ionutleca commented 3 years ago

The CLA was approved a long time ago.

bm77525-kr commented 3 years ago

Apologies, the timeline was a bit confusing. It’s a shame because this is super useful, but they seemed to let it fall by the wayside.

ionutleca commented 3 years ago

No worries. It seems useful to me as well, but we might be the only ones :))

bm77525-kr commented 3 years ago

@nishubansal @N-Usha @anweiss Can anyone finally get this merged in?

utricularia commented 3 years ago

Any chance either this or the PR for adding build parameters might get merged in?

JamesBurnside commented 3 years ago

+1 to getting this merged in