Azure / pipelines

Enable GitHub developers to trigger Azure Pipelines from a GitHub Actions workflow
MIT License
73 stars 83 forks source link

Predefined `Build.SourceBranch` variable not working #38

Open ofir123 opened 3 years ago

ofir123 commented 3 years ago

Hi,

We're trying to migrate from pr triggers in the azure-pipeline.yml to a GitHub Action trigger, using the following action:

  ...
  azure_pipeline:
    needs: [previous_action]
    runs-on: ubuntu-latest
    steps:
      - name: Azure Pipelines Action
        uses: Azure/pipelines@v1
        with:
          azure-devops-project-url: https://dev.azure.com/organization/project
          azure-pipeline-name: cogz-ci
          azure-devops-token: ${{ secrets.AZURE_DEVOPS_TOKEN }}

The trigger works great, but some of the build information is missing.

For example, our build name in the azure-pipeline.yml file is defined as follows: name: cogz-ci-$(branchName)-$(Date:yyyyMMdd)$(Rev:.rr) branchName is defined in a global template as:

  ${{ if startsWith(variables['Build.SourceBranch'], 'refs/pull/') }}:
    branchName: $[ replace(replace(replace(variables['system.pullRequest.sourceBranch'], 'refs/heads/', ''), '\', '-'), '/', '-') ]
  ${{ if startsWith(variables['Build.SourceBranch'], 'refs/heads/') }}:
    branchName: $[ replace(replace(replace(variables['build.sourceBranch'], 'refs/heads/', ''), '\', '-'), '/', '-') ]

When running with the azure pipelines PR trigger, we get: image

But when running with the GitHub Action trigger, we get: image (the build also fails because we're using branchName in a lot of places)

Are we missing something? Should this be passed as a variable when using the GitHub Action trigger?

Thanks!

tjcorr commented 10 months ago

I would recommend using the Azure Pipeline App in the GitHub marketplace: https://github.com/marketplace/azure-pipelines. Using this app will allow you to directly trigger a Azure Pipeline without the need for GitHub Actions at all. I believe this will also make all the ADO build variables function as expected.

vwnj84 commented 2 days ago

@tjcorr Who actually supports the app? We've had all kinds of trouble with that integration and Microsoft support treats it as if they've never heard of it.