search

Azure / pipelines

Enable GitHub developers to trigger Azure Pipelines from a GitHub Actions workflow
MIT License
73 stars 83 forks source link

Bump action environment from Node12 to Node16 #73

Closed devenes closed 10 months ago

devenes commented 1 year ago

🚨 Node 12 has an end of life on April 30, 2022.

As mentioned in the issue https://github.com/Azure/pipelines/issues/70, The GitHub Actions workflow gives the following deprecation warning while running the action:

Node.js 12 actions are deprecated. For more information see: github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12.

This PR updates the default runtime to node16 rather then node12.

This is supported on all Actions Runners v2.285.0 or later.

Signed-off-by: Enes ahmedenesturan@gmail.com

thefueley commented 1 year ago

Can this get approved?

bartoszkosiorek commented 1 year ago

It is an blocker for using this action on Apple M1 devices, as the error:

The node12 is not supported on macOS ARM64 platform. Use node16 instead.

is displayed. @Josh-01 @kanika1894 Do you think this PR could be merged to master branch?

tjcorr commented 10 months ago

Closing this as resolved by #79

shealavington commented 10 months ago

@tjcorr I don't suppose it's possible to know when there might be a patch or release for the node update change?

I would think that semantically, it should be v1.2.1. Looking at your structure though, it looks like you're doing minor releases (next release being v1.3), and I'm not sure how often you release the minor changes.

I ask due to the node deprecation, seems like this is better to be out sooner rather than later.

https://github.com/Azure/pipelines/tags