Closed bengreenier closed 6 years ago
@Azure/platform-chaos this technically breaks our own PR guidelines as it doesn't include adequate testing. I don't have the bandwidth to implement those at this moment, does anyone else? Or does anyone have feedback on how we should best proceed?
Can i get a 👍 for block on testing, and a 👎 for ship without tests and circle back
I personally think that we should block on testing, even if that means forward progress is put on hold until that happens. It'll only get harder to integrate proper testing.
@gavination do you have any cycles to work on this? Perhaps we can work together on it.
@trstringer, I sure do! I'm more than happy to work on it together. It'll be good insight to get a proper testing structure in early.
@trstringer I know you aren't the biggest standard fan, but most of the project's code conformed to that style so that is the linter configuration @gavination and I went with. Hope that makes sense 😸
Hehehe makes total sense!!
Description
This adds:
Checklist for success