search

Azure / platform-chaos

A node sdk for building services capable of injecting chaos into PaaS offerings. ⚙️ 🌩
MIT License
18 stars 7 forks source link

package json needs updated publisher information #12

Closed bengreenier closed 6 years ago

bengreenier commented 6 years ago

The package.json file currently still lists bengreenier as a publisher, it should instead say microsoft.

Ethan-Arrowood commented 6 years ago

Can I include this fix in ~#14~ #19 ?

bengreenier commented 6 years ago

@Ethan-Arrowood short answer: probably.

longer answer: What i'd ideally like to see if we go that route is clarity at the commit level. You'd want to rebase and merge (not squash and merge) and have one commit that fixes #11 and one that fixes this.

Ethan-Arrowood commented 6 years ago

Okay so even though PRs are limited to squash and merging I can (locally) rebase and merge multiple commits in one PR -- I'll go ahead a push to my open pr branch now

bengreenier commented 6 years ago

@Ethan-Arrowood no that isn't necessary - we can modify our github configuration to allow rebase and merge. see https://github.com/orgs/Azure/teams/platform-chaos/discussions/5 for our internal discussion on the matter (sorry folks who don't have visibility here)

bengreenier commented 6 years ago

closed in https://github.com/Azure/platform-chaos/pull/19