Feature/add auditing monkeypatch

Azure / platform-chaos

A node sdk for building services capable of injecting chaos into PaaS offerings. ⚙️ 🌩

MIT License

18 stars 7 forks source link

Feature/add auditing monkeypatch #28

Closed Ethan-Arrowood closed 6 years ago

Ethan-Arrowood commented 6 years ago

Description

This PR adds the preliminary implementation of extension based auditing. Looking forward to feedback as well as some input on how to test this.

to do:

[x] Add documentation
[ ] Test through implementation (locally)
[x] Test through unit tests

Checklist for success

[x] This change isn't already implemented by a pending pull request
[x] This change is a child commit of a reasonably recent commit in the master branch
- Requests need not be a single commit, but should be a linear sequence of commits (i.e. no merge commits in your PR)
[x] All tests pass locally (see the testing section for more info)
[ ] All New behaviors or major functional changes have tests

Ethan-Arrowood commented 6 years ago

My last commit should clean up some of Ben's code changes. I'm running into some issues developing a functional example, but still working at it. I'm going to hold off on doc changes until I figure out implementation.

Also what should I do instead of throwing an error? Could I use console.warn or something like that?

Ethan-Arrowood commented 6 years ago

🎉woo! implementation works! I modified the code from the tutorial wiki with my auditer (used npm link to use local version of package). Notice in the top right there is a list of 'audits' being output from line 30 of the file on the left. Thomas' published chaos event is sorta broken, tomorrow I'll be able to focus on a pr updating it.

Only thing left for this PR is documentation and deciding what to do about the error line.

auditdemo

Ethan-Arrowood commented 6 years ago

I have opened a PR on Thomas' extension that once merged will reference in the documentation for this feature addition https://github.com/trstringer/azure-chaos-fn-webapp-startstop/pull/1

Ethan-Arrowood commented 6 years ago

Getting close on this one. I'd like to include an example extension (Thomas' thing) in the documentation. Now that I've settled the --resources issue I have to retest everything and make sure it is working as expected too.