Azure / postgresql

Deploy to an Azure PostgreSQL database using PLSQL scripts.
MIT License
23 stars 15 forks source link

Support `psql` as part of the server host #48

Open michaelcontento opened 1 year ago

michaelcontento commented 1 year ago

According to the CAF (Cloud Adoption Framework) the official abbreviation for a PostgreSQL database is psql.

But the current implementation blindly replaces 'psql' with '', which breaks the ability to use this action with such a named DB.

Input:

      - uses: azure/postgresql@v1
        with:
          connection-string: host=caf-named-db-psql.postgres.database.azure.com ...

Output:

psql: error: could not translate host name "caf-named-db-.postgres.database.azure.com" to address: Name or service not known
Error: Error occurred while running action:
Error: The process '/usr/bin/psql' failed with exit code 2

Personal workaround:

The code currently not only replaces 'psql' with '', it also (as a second step) replaces '"' with ''. So a functional workaround that I use is adding a rouge " like this:

      - uses: azure/postgresql@v1
        with:
          connection-string: host=caf-named-db-p"sql.postgres.database.azure.com ...

But this is far from ideal 😂

spowser commented 11 months ago

Created a fork and published a release spowser/postgresql@v2 to address this issue until they merge the PR