Azure / prometheus-collector

Other
58 stars 35 forks source link

fix: add single quotes to pod annotations for multiple namespace scenario #927

Closed bragi92 closed 2 days ago

bragi92 commented 1 week ago

Full issue description can be found here

Essentially if you have the following in the configmap podannotationnamespaceregex = "gegc|gegd"

Then the pipe is being read as a command separator by the shell script here and its unable to set the values throwing an error ->

/root/.bashrc: line 9: gegd: command not found

We can fix this by making the value a string and adding quotes around it as done in this PR.

PR Description

New Feature Checklist

Tests Checklist