search

Azure / pytest-azurepipelines

Plugin for pytest that makes it simple to work with Azure Pipelines
MIT License
113 stars 35 forks source link

Option for not uploading code-coverage #27

Closed shoyer closed 5 years ago

shoyer commented 5 years ago

pytest-azurepipelines is very nice -- thanks for your work on it!

We are currently publishing test coverage to codecov.io, but not Azure, because I don't know how to merge coverage results across multiple runs: https://stackoverflow.com/questions/56776185

It is possible to add an option of some sort for disabling the warning about not uploading coverage? Right now, I see ##[warning]Coverage XML was not created, skipping upload. in my logs.

tonybaloney commented 5 years ago

hi @shoyer the feature is supposed to just skip when coverage is not found.

I could certainly add a flag to disable this

tonybaloney commented 5 years ago

Added in #29

shoyer commented 5 years ago

Thanks @tonybaloney.

It might also make sense to use this option to disable setting the path for coverage xml output: https://github.com/tonybaloney/pytest-azurepipelines/blob/508540fe79f0f8c15512baddb07a1d9dd1e7bff3/pytest_azurepipelines.py#L69

Or maybe pytest-azurepipelines could avoid changing this option at all, if it's already set?

I found it a little surprising that pytest-azurepipelines changed this, which turned out to mean that codecov.io couldn't find coverage results under the default path (coverage.xml): https://github.com/pydata/xarray/pull/3085

shoyer commented 5 years ago

The codecov.io uploader actually hard-codes the name coverage.xml: https://github.com/codecov/codecov-bash/blob/4678d212cce2078bbaaf5027af0c0dafaad6a095/codecov#L963

Unfortunately I couldn't figure out how override this option from pytest-azurepipelines, so for now I've had to remove it from my project to ensure we get test coverage.

tonybaloney commented 5 years ago

Thanks. I’m working on a release today so I’ll get this fixed

Anthony Shaw

From: Stephan Hoyer notifications@github.com Sent: Saturday, July 6, 2019 11:09 am To: tonybaloney/pytest-azurepipelines Cc: Anthony Shaw; Mention Subject: Re: [tonybaloney/pytest-azurepipelines] Option for not uploading code-coverage (#27)

The codecov.io uploader actually hard-codes the name coverage.xml: https://github.com/codecov/codecov-bash/blob/4678d212cce2078bbaaf5027af0c0dafaad6a095/codecov#L963

Unfortunately I couldn't figure out how override this option from pytest-azurepipelines, so for now I've had to remove it from my project to ensure we get test coverage.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/tonybaloney/pytest-azurepipelines/issues/27?email_source=notifications&email_token=AALWEAKXRMLRYPM5HGZIXKTP57WFLA5CNFSM4H5SXVH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZKP3DA#issuecomment-508886412, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AALWEAPGZ4XKIZOMO3HH44DP57WFLANCNFSM4H5SXVHQ.

tonybaloney commented 5 years ago

released in 0.8.0