added kv recommendation and arg query 05.01 - Githubissues

Azure / review-checklists

This repo contains code and examples to operationalize Azure review checklists.

MIT License

1.2k stars 324 forks source link

added kv recommendation and arg query 05.01 #913

Closed cshea-msft closed 2 months ago

cshea-msft commented 2 months ago

Description

Please provide a detailed description of your changes.

Added a new recommendation to check if RBAC is configured on KV and added the query

Related Issue

Link to any related issues or discussions here. This helps reviewers understand the context and the need for your changes.

Checklist

[ X] I've tested my changes to ensure they are ready for review.
[ ] I've read the CONTRIBUTING.md guide.
[ X] I've updated the documentation (if applicable).
[ X] Resource Graph queries have been included (and tested) for recommendations where ever possible[^note].
[ ] Resource Graph queries have NOT been included (please explain below).

Additional Information

Is there any additional context, screenshots, or considerations that might help in the review process? Please include them here.

Reviewer Notes

Is there a specific area you’d like feedback on? Please highlight it here. We're here to help and learn together! 💡

[^note]: Details on how to add Azure Resource Graph queries to recommendations can be found here.