Naigaras sap6 arg

[NaokiIgarashi]

Description

As part of our Hackathon 2024 activities, we added 20 ARG queries to the SAP checklist.

Related Issue

non

Checklist

• [x] I've tested my changes to ensure they are ready for review.
• [x] I've read the CONTRIBUTING.md guide.
• [ ] I've updated the documentation (if applicable).
• [x ] Resource Graph queries have been included (and tested) for recommendations where ever possible[^note].
• [ ] Resource Graph queries have NOT been included (please explain below).

Additional Information

Lines 613 and 1140 are highlighted (red), but there were no problems with the execution results of the query itself.

Reviewer Notes

Is there a specific area you’d like feedback on? Please highlight it here. We're here to help and learn together! 💡 review_checklist (SAP)_nonmacro_Naoki+Syed.xlsx

[^note]: Details on how to add Azure Resource Graph queries to recommendations can be found here.

[NaokiIgarashi]

Hello @erjosito ! Thank you for pointing that out! I've corrected all the things you pointed out, but there are still many == cases remaining. Would it be better to change them all to =~?

[erjosito]

I would suggest to do that. By using =~ your queries will be more solid, in case the PG changes the casing of provider names or property keys or values.

[NaokiIgarashi]

Hey @erjosito ,

i modified all the character from == to =~ . please check it!

[erjosito]

Fantastic thanks a lot @NaokiIgarashi !