search

Azure / sap-automation

This is the repository supporting the SAP deployment automation framework on Azure
MIT License
122 stars 142 forks source link

Add SAP on Azure quality chekcs feature to the 05-DB-and-SAP-installation pipeline #595

Closed SteffenBoThomsen closed 4 months ago

SteffenBoThomsen commented 4 months ago

Problem

Azure provides a SAP on Azure quality check script in it's https://github.com/Azure/SAP-on-Azure-Scripts-and-Utilities repository Running this quality check, ensures that misconfigurations on infrastructure might be caught earlier.

Solution

Implement the Quality Check script, to run against target VMs from the deployer as a separate step in the DB and installation pipeline.

FIX: a duplicate code block from a merge has been removed from the 05 pipeline.

BE AWARE this PR is closely linked with a PR in sap-automation-bootstrap

devanshjainms commented 4 months ago

Hi @SteffenBoThomsen , Thanks for sharing the PR. We are fixing a few issues in the experimental branch now. Can you please rebase this branch off experimental, and then we can merge it.

SteffenBoThomsen commented 4 months ago

Hi @SteffenBoThomsen , Thanks for sharing the PR. We are fixing a few issues in the experimental branch now. Can you please rebase this branch off experimental, and then we can merge it.

@devanshjainms Done, will it be included in the next release?