Azure / sap-automation

This is the repository supporting the SAP deployment automation framework on Azure
MIT License
121 stars 137 forks source link

fix: saptune should not fail on NA parameters. #602

Closed SteffenBoThomsen closed 2 months ago

SteffenBoThomsen commented 2 months ago

Problem

When running saptune solution verify, an error is thrown, when some parameters are misconfigured from saptunes perspective, even though they do not apply to the type of system, e.g;

   2684254, 23      | governor                           | all:performance             |           | all:powersave               | no
   2684254, 23      | grub:intel_idle.max_cstate         | 1                           |           | NA                          | no  [2] [3] [6]
   2684254, 23      | grub:numa_balancing                | disable                     |           | NA                          | no  [2] [3] [6]
   2684254, 23      | grub:processor.max_cstate          | 1                           |           | NA                          | no  [2] [3] [6]
   2684254, 23      | grub:transparent_hugepage          | never                       |           | NA                          | no  [2] [3] [6]

In this example, note 2684254 also affects other parameters, like:

   2684254, 23      | KSM                                | 0                           |           | 0                           | yes
   2684254, 23      | THP                                | never                       |           | never                       | yes
   2684254, 23      | energy_perf_bias                   | all:0                       |           | all:none                    |  -  [1]
   2684254, 23      | force_latency                      | 70                          |           | all:none                    |  -  [1]
   2684254, 23      | kernel.numa_balancing              | 0                           |           | 0                           | yes

Solution

Set failed_when to false, to not fail on NA parameters.