search

Azure / secrets-store-csi-driver-provider-azure

Azure Key Vault provider for Secret Store CSI driver allows you to get secret contents stored in Azure Key Vault instance and use the Secret Store CSI driver interface to mount them into Kubernetes pods.
https://azure.github.io/secrets-store-csi-driver-provider-azure/
MIT License
432 stars 191 forks source link

fix: cert chain sorting when the leaf certificate is missing the SubjectKeyIdentifier extension #1509

Closed Cisien closed 3 months ago

Cisien commented 3 months ago

Reason for Change: This PR fixes #1257 where the fetchCertChain function is unable to resolve the leaf certificate when sorting the chain. This is caused by the leaf certificate missing the optional SubjectKeyIdentifier extension, therefore getting matched as the parent to the CA certificate.

Requirements

Issue Fixed:

1257

Does this change contain code from or inspired by another project?

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers: I work for Microsoft, alias: chriscur

codecov-commenter commented 3 months ago

Codecov Report

Merging #1509 (abf3ce7) into master (577f7d6) will increase coverage by 0.06%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1509 +/- ## ========================================== + Coverage 56.69% 56.75% +0.06% ========================================== Files 17 17 Lines 1300 1302 +2 ========================================== + Hits 737 739 +2 Misses 537 537 Partials 26 26 ```
aramase commented 3 months ago

/azp run pr-e2e

azure-pipelines[bot] commented 3 months ago
Azure Pipelines successfully started running 1 pipeline(s).
azure-pipelines[bot] commented 3 months ago
No pipelines are associated with this pull request.
aramase commented 3 months ago

/azp run pr-e2e

azure-pipelines[bot] commented 3 months ago
Azure Pipelines successfully started running 1 pipeline(s).
aramase commented 3 months ago

/azp run pr-e2e-azure

azure-pipelines[bot] commented 3 months ago
No pipelines are associated with this pull request.