search

Azure / service-catalog-cli

See the upstream repository ->
https://github.com/kubernetes-incubator/service-catalog
MIT License
33 stars 14 forks source link

Put all the "standard flourishes" on the build / CI process #26

Closed krancour closed 6 years ago

krancour commented 6 years ago

As has been our custom, I'd like to see the build and tests occur within a container to ensure 100% environmental consistency among contributors and between contributors and CI.

I'd also like to see the battery of tests we run during CI expand to include lint checks, vendor code validation, etc.

I know this sounds like busy work, but I always enjoy greasing the wheels in this manner. I'm volunteering for this.

carolynvs commented 6 years ago

Sounds great! I'm working on adding unit tests as well. I'll add a issue to make it clear which parts on tackling.

arschles commented 6 years ago

Agree RE lint checks, etc...

Containerized builds, tests, etc... are all good. I'd like to make sure that everything can also be done directly on the host - so that CircleCI can run them inside of its containers

krancour commented 6 years ago

I'd like to make sure that everything can also be done directly on the host - so that CircleCI can run them inside of its containers

I'll make sure of it. Should be easier here than with OSBA because there's no need (that I'm aware of) to coordinate multiple containers-- e.g. no need for compose. This translates into the option of leveraging some new tricks I have up my sleeve. This should be entirely doable.