search

Azure / service-fabric-mesh-preview

Service Fabric Mesh is the Service Fabric's serverless offering to enable developers to deploy containerized applications without managing infrastructure. Service Fabric Mesh , aka project “SeaBreeze” is currently available in private preview. This repository will be used for tracking bugs/feature requests as GitHub issues and for maintaining the latest documentation.
MIT License
82 stars 13 forks source link

Nuget support for sfaproj #153

Open allanFunrock opened 6 years ago

allanFunrock commented 6 years ago

With the move to the modern proj format, automatic target/props generation is now supported for nuget packages. However (in addition to #152) In order for dotnet restore to work, a TargetFramework needs to be set.

Including a <TargetFramework>netstandard2.0</TargetFramework> in the project files resolves the issue and lets packages be restored. This should be added to Microsoft.SFApp.Sdk\Sdk\Sdk.props

Also, the Vs tooling doesn't not seem to support adding packages at all, even project references doesn't seem to be supported. ~i'm still looking into the new resource format but it seems like sfaprojs don't contain any kind of reference to the projects witch seems a little strage. I think they should be project references like in the old model~ (moved to a separate issue, #154 )

BigMorty commented 6 years ago

@sgreenmsft

sgreenmsft commented 6 years ago

Do I understand correctly that your goal is to have PackageReference elements supported in sfaproj files? If so, could you elaborate on the scenarios you're interested in enabling with that? Thanks!

allanFunrock commented 6 years ago

Yes that is correct. I have a project extending the build process that is extending the build process that is distributed as a nuget package. It would allow others to more easily do the same and it's a very small change.

It's available on GitHub https://github.com/aL3891/ServiceFabricSdkContrib

Get Outlook for Androidhttps://aka.ms/ghei36

From: sgreenmsft notifications@github.com Sent: Tuesday, June 26, 2018 1:17:14 AM To: Azure/service-fabric-mesh-preview-pr Cc: Allan Lindqvist; Author Subject: Re: [Azure/service-fabric-mesh-preview-pr] Nuget support for sfaproj (#153)

Do I understand correctly that your goal is to have PackageReference elements supported in sfaproj files? If so, could you elaborate on the scenarios you're interested in enabling with that? Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Azure/service-fabric-mesh-preview-pr/issues/153#issuecomment-400125271, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AZnzl6PYpAi7iuC46RORiD6H-R56egdoks5uAW95gaJpZM4U0g2h.

allanFunrock commented 6 years ago

Another scenario for this is services as packages witch would allow for services to be build separatley and then brought together at deploy time, something that would make working in large teams with many discreet services alot easier.

yet another scenario is adding parameters to the (classic) app.xml file from services at build time and some things that i already do today in sfcontrib, setting versions based on service files and creating diff packages