search

Azure / service-fabric-mesh-preview

Service Fabric Mesh is the Service Fabric's serverless offering to enable developers to deploy containerized applications without managing infrastructure. Service Fabric Mesh , aka project “SeaBreeze” is currently available in private preview. This repository will be used for tracking bugs/feature requests as GitHub issues and for maintaining the latest documentation.
MIT License
82 stars 12 forks source link

Deployment continues even when the image is missing #312

Open SamirFarhat opened 5 years ago

SamirFarhat commented 5 years ago

Hi, I noticed that when i deploy a SFM app, the deployment continues even when the image (Azure container registry) does not exist. I rather expected that an error message is thrown saying that the image does not exist. image

Is this a bug ?

SamirFarhat commented 5 years ago

The behavior is the same even when i provide a bad password of the CR server

jeffj6123 commented 5 years ago

Did the deployment eventually ever timeout?

SamirFarhat commented 5 years ago

I cancelled the deployment before its timed out, so i don't know if it will timeout. My problem is that it should fire an error as long as the image does not exist

robinmanuelthiel commented 5 years ago

Had a similar issue with a container that did not exist in the container repository. For me it timed out.

Deployment failed. Correlation ID: dfde86d3-1302-438e-ba48-2eaae9576101. {
  "status": "Canceled",
  "error": {
    "code": "ResourceDeploymentFailure",
    "message": "The resource operation completed with terminal provisioning state 'Canceled'.",
    "details": [
      {
        "code": "RequestTimeout",
        "message": "The request timed out.",
        "details": []
      }
    ]
  }
}

We need checks if registry access and container names are valid!