Upgrade action to use node20

Azure / setup-helm

Github Action for installing Helm

MIT License

141 stars 48 forks source link

Upgrade action to use node20 #121

Closed bonddim closed 9 months ago

bonddim commented 9 months ago

Bump all dependencies to use node20
Bump stableHelmVersion to v3.13.3 (latest patch of previous minor version)
Rewrite getLatestHelmVersion() function with @octokit/action
Bump versions of used actions in workflows to latest
Added integration test for latest version
Sets github.token as default input

Fixes #120 Fixes #117 Closes #116 Closes #115 Closes #114 Closes #112

hangai247 commented 9 months ago

I think this change is going to be a Breaking change that should create a new action version azure/setup-helm@v4. Since all our workflows that are utilizing this action have started giving Nodejs v16 deprecation warnings, looking forward to the merging of this pull request.

tamer-abdulghani commented 9 months ago

Any idea about the date for the new release?

bonddim commented 9 months ago

I think this change is going to be a Breaking change that should create a new action version azure/setup-helm@v4. Since all our workflows that are utilizing this action have started giving Nodejs v16 deprecation warnings, looking forward to the merging of this pull request.

Any updates? There are no breaking changes for users - action will be usable with v3

- uses: azure/setup-helm@v3
  with:
    ...

You may bump major version to indicate the runtime change.

jkroepke commented 9 months ago

There are no breaking changes for users

The runtime change must be indicated as breaking change, since it may break on private runners or GHES

davidgamero commented 9 months ago

@hangai247 yes we can cut a new release once this is merged

minauteur commented 9 months ago

Any word on when a v4 release will be cut?

davidgamero commented 8 months ago

tracking here https://github.com/Azure/setup-helm/pull/125

on target by end of this week at the latest