Azure / setup-kubectl

GitHub Action for installing Kubectl
MIT License
132 stars 50 forks source link

Bump to Node 20 #94

Closed andriiholubenko closed 9 months ago

andriiholubenko commented 9 months ago

changes already merged into main branch but not released. do you have any news?

davidgamero commented 9 months ago

yes the new release workflow is being added this week which will unblock this

andriiholubenko commented 9 months ago

thank you

pacoguzman commented 9 months ago

Hi there,

I think there is an issue with the new release workflow. As you can see after the last merge onto main the release workflow failed

[Invalid workflow file: .github/workflows/release-pr.yml#L16](https://github.com/Azure/setup-kubectl/actions/runs/7718484552/workflow)
error parsing called workflow
".github/workflows/release-pr.yml"
-> "Azure/action-release-workflows/.github/workflows/release_js_project.yaml@e4a1a0385530d6861c9a9b7262058ad33b10c769"
: failed to fetch workflow: workflow was not found.

I'm not totally sure how that works but if e4a1a0385530d6861c9a9b7262058ad33b10c769 is a commit sha on the other repository, that commit does not exist -> https://github.com/Azure/action-release-workflows/commit/e4a1a0385530d6861c9a9b7262058ad33b10c769

I hope this help to debug the issue.

perkrlsn commented 9 months ago

@davidgamero any news on this? As @pacoguzman pointed out it seems like the release has failed.

I created a PR to set the version on action-release-workflows to the latest release version.

davidgamero commented 9 months ago

thank you @perkrlsn i have updated the hash for the workflow and cut release v4.0.0

please let me know if you encounter any issues with the new release 😄

perkrlsn commented 9 months ago

Thanks @davidgamero, it works like charm :+1: The node 16 deprecation notice is gone 🥳

davidgamero commented 9 months ago

i am glad to hear that it is working

closing this issue for now, we can reopen if a further issue is discovered