search

Azure / spring-apps-deploy

GitHub Actions to deploy to Azure Spring Cloud
MIT License
12 stars 9 forks source link

Deployment fails with Error: Action failed with error: deploymentName cannot be null or undefined. #18

Open ezYakaEagle442 opened 1 year ago

ezYakaEagle442 commented 1 year ago

I have a GH Workflow to deploy my *.jar files to ASA which did run fine so far, since the latest release of the ASA GH Action, it does not work anymore.

Deployment fails with the error below : Error: Action failed with error: deploymentName cannot be null or undefined.

Whereas all the Runner logs show that the deployment-name param was successfully provided : deployment-name: blue-vets-service

see https://github.com/ezYakaEagle442/azure-spring-apps-petclinic-mic-srv/actions/runs/3322102903/jobs/5491343365 : 

##[debug]Evaluating condition for step: 'Deploy vets-service'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Deploy vets-service
##[debug]Loading inputs
##[debug]Evaluating: secrets.AZURE_SUBSCRIPTION
##[debug]Evaluating Index:
##[debug]..Evaluating secrets:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'AZURE_SUBSCRIPTION'
##[debug]=> '***'
##[debug]Result: '***'
##[debug]Evaluating: env.AZURE_SPRING_APPS_SERVICE
##[debug]Evaluating Index:
##[debug]..Evaluating env:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'AZURE_SPRING_APPS_SERVICE'
##[debug]=> 'asa-petcliasa'
##[debug]Result: 'asa-petcliasa'
##[debug]Evaluating: env.VETS_SERVICE
##[debug]Evaluating Index:
##[debug]..Evaluating env:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'VETS_SERVICE'
##[debug]=> 'vets-service'
##[debug]Result: 'vets-service'
##[debug]Evaluating: env.DEPLOYMENT_STAGING
##[debug]Evaluating Index:
##[debug]..Evaluating env:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'DEPLOYMENT_STAGING'
##[debug]=> 'true'
##[debug]Result: 'true'
##[debug]Evaluating: needs.build.outputs.VETS_SERVICE_PACKAGE_PATH
##[debug]Evaluating Index:
##[debug]..Evaluating Index:
##[debug]....Evaluating Index:
##[debug]......Evaluating needs:
##[debug]......=> Object
##[debug]......Evaluating String:
##[debug]......=> 'build'
##[debug]....=> Object
##[debug]....Evaluating String:
##[debug]....=> 'outputs'
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'VETS_SERVICE_PACKAGE_PATH'
##[debug]=> '/home/runner/work/azure-spring-apps-petclinic-mic-srv/azure-spring-apps-petclinic-mic-srv/vets-service/asa-spring-petclinic-vets-service-2.6.6.jar'
##[debug]Result: '/home/runner/work/azure-spring-apps-petclinic-mic-srv/azure-spring-apps-petclinic-mic-srv/vets-service/asa-spring-petclinic-vets-service-2.6.6.jar'
##[debug]Evaluating: env.DEPLOYMENT_JVM_OPTIONS
##[debug]Evaluating Index:
##[debug]..Evaluating env:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'DEPLOYMENT_JVM_OPTIONS'
##[debug]=> '-Dspring.cloud.azure.keyvault.secret.endpoint=https://kv-petcliasa21.vault.azure.net -Dspring.cloud.azure.keyvault.secret.property-sources[0].endpoint=https://kv-petcliasa21.vault.azure.net -Dspring.cloud.azure.keyvault.secret.property-sources[1].endpoint=https://kv-petcliasa21.vault.azure.net -Dspring.cloud.azure.keyvault.secret.property-sources[2].endpoint=https://kv-petcliasa21.vault.azure.net -Xms[51](https://github.com/ezYakaEagle442/azure-spring-apps-petclinic-mic-srv/actions/runs/3322102903/jobs/5491343365#step:5:51)2m -Xmx1024m -Dspring.profiles.active=mysql,key-vault,cloud'
##[debug]Result: '-Dspring.cloud.azure.keyvault.secret.endpoint=https://kv-petcliasa21.vault.azure.net -Dspring.cloud.azure.keyvault.secret.property-sources[0].endpoint=https://kv-petcliasa21.vault.azure.net -Dspring.cloud.azure.keyvault.secret.property-sources[1].endpoint=https://kv-petcliasa21.vault.azure.net -Dspring.cloud.azure.keyvault.secret.property-sources[2].endpoint=https://kv-petcliasa21.vault.azure.net -Xms512m -Xmx1024m -Dspring.profiles.active=mysql,key-vault,cloud'
##[debug]Evaluating: format('-SPRING_CLOUD_AZURE_KEY_VAULT_ENDPOINT ***0*** -VETS_SVC_APP_IDENTITY_CLIENT_ID ***1*** -SPRING_CLOUD_AZURE_TENANT_ID ***2***', env.SPRING_CLOUD_AZURE_KEY_VAULT_ENDPOINT, env.VETS_SVC_APP_IDENTITY_CLIENT_ID, env.SPRING_CLOUD_AZURE_TENANT_ID)
##[debug]Evaluating format:
##[debug]..Evaluating String:
##[debug]..=> '-SPRING_CLOUD_AZURE_KEY_VAULT_ENDPOINT ***0*** -VETS_SVC_APP_IDENTITY_CLIENT_ID ***1*** -SPRING_CLOUD_AZURE_TENANT_ID ***2***'
##[debug]..Evaluating Index:
##[debug]....Evaluating env:
##[debug]....=> Object
##[debug]....Evaluating String:
##[debug]....=> 'SPRING_CLOUD_AZURE_KEY_VAULT_ENDPOINT'
##[debug]..=> '***'
##[debug]..Evaluating Index:
##[debug]....Evaluating env:
##[debug]....=> Object
##[debug]....Evaluating String:
##[debug]....=> 'VETS_SVC_APP_IDENTITY_CLIENT_ID'
##[debug]..=> '7c4fdc76-698e-4a[53](https://github.com/ezYakaEagle442/azure-spring-apps-petclinic-mic-srv/actions/runs/3322102903/jobs/5491343365#step:5:53)-aac8-1e594f4e4a[54](https://github.com/ezYakaEagle442/azure-spring-apps-petclinic-mic-srv/actions/runs/3322102903/jobs/5491343365#step:5:54)'
##[debug]..Evaluating Index:
##[debug]....Evaluating env:
##[debug]....=> Object
##[debug]....Evaluating String:
##[debug]....=> 'SPRING_CLOUD_AZURE_TENANT_ID'
##[debug]..=> '***'
##[debug]=> '-SPRING_CLOUD_AZURE_KEY_VAULT_ENDPOINT *** -VETS_SVC_APP_IDENTITY_CLIENT_ID 7c4fdc76-698e-4a53-aac8-1e[59](https://github.com/ezYakaEagle442/azure-spring-apps-petclinic-mic-srv/actions/runs/3322102903/jobs/5491343365#step:5:59)4f4e4a54 -SPRING_CLOUD_AZURE_TENANT_ID ***'
##[debug]Result: '-SPRING_CLOUD_AZURE_KEY_VAULT_ENDPOINT *** -VETS_SVC_APP_IDENTITY_CLIENT_ID 7c4fdc76-[69](https://github.com/ezYakaEagle442/azure-spring-apps-petclinic-mic-srv/actions/runs/3322102903/jobs/5491343365#step:5:69)8e-4a53-aac8-1e5[94](https://github.com/ezYakaEagle442/azure-spring-apps-petclinic-mic-srv/actions/runs/3322102903/jobs/5491343365#step:5:94)f4e4a54 -SPRING_CLOUD_AZURE_TENANT_ID ***'
##[debug]Evaluating: needs.build.outputs.VETS_SERVICE_DEPLOYMENT
##[debug]Evaluating Index:
##[debug]..Evaluating Index:
##[debug]....Evaluating Index:
##[debug]......Evaluating needs:
##[debug]......=> Object
##[debug]......Evaluating String:
##[debug]......=> 'build'
##[debug]....=> Object
##[debug]....Evaluating String:
##[debug]....=> 'outputs'
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'VETS_SERVICE_DEPLOYMENT'
##[debug]=> 'blue-vets-service'
##[debug]Result: 'blue-vets-service'
##[debug]Evaluating: env.DEPLOYMENT_CREATE_NEW
##[debug]Evaluating Index:
##[debug]..Evaluating env:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'DEPLOYMENT_CREATE_NEW'
##[debug]=> 'true'
##[debug]Result: 'true'
##[debug]Evaluating: env.DEPLOYMENT_VERSION
##[debug]Evaluating Index:
##[debug]..Evaluating env:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'DEPLOYMENT_VERSION'
##[debug]=> '2.6.6'
##[debug]Result: '2.6.6'
##[debug]Evaluating: env.DEPLOYMENT_RUNTIME_VERSION
##[debug]Evaluating Index:
##[debug]..Evaluating env:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'DEPLOYMENT_RUNTIME_VERSION'
##[debug]=> 'Java_11'
##[debug]Result: 'Java_11'
##[debug]Loading env

Run Azure/spring-apps-deploy@v1.1.0
  with:
    azure-subscription: ***
    action: deploy
    service-name: asa-petcliasa
    app-name: vets-service
    use-staging-deployment: true
    package: /home/runner/work/azure-spring-apps-petclinic-mic-srv/azure-spring-apps-petclinic-mic-srv/vets-service/asa-spring-petclinic-vets-service-2.6.6.jar
    jvm-options: -Dspring.cloud.azure.keyvault.secret.endpoint=https://kv-petcliasa21.vault.azure.net -Dspring.cloud.azure.keyvault.secret.property-sources[0].endpoint=https://kv-petcliasa21.vault.azure.net -Dspring.cloud.azure.keyvault.secret.property-sources[1].endpoint=https://kv-petcliasa21.vault.azure.net -Dspring.cloud.azure.keyvault.secret.property-sources[2].endpoint=https://kv-petcliasa21.vault.azure.net -Xms512m -Xmx1024m -Dspring.profiles.active=mysql,key-vault,cloud
    environment-variables: -SPRING_CLOUD_AZURE_KEY_VAULT_ENDPOINT *** -VETS_SVC_APP_IDENTITY_CLIENT_ID 7c4fdc76-698e-4a53-aac8-1e594f4e4a54 -SPRING_CLOUD_AZURE_TENANT_ID ***
    deployment-name: blue-vets-service
    create-new-deployment: true
    version: 2.6.6
    runtime-version: Java_11
  env:
    AZ_CLI_VERSION: 2.40.0
    AZURE_SPRING_APPS_SERVICE: asa-petcliasa
    KEYVAULT: kv-petcliasa21
    RG_APP: rg-iac-asa-petclinic-mic-srv
    AZ_STORAGE_NAME: stasapetcliasa
    AZ_BLOB_CONTAINER_NAME: petcliasa-blob
    AZ_BLOB_MAX_CONNECTIONS: 5
StartingUploadOf/home/runner/work/azure-spring-apps-petclinic-mic-srv/azure-spring-apps-petclinic-mic-srv/vets-service/asa-spring-petclinic-vets-service-2.6.6.jar
*** loadedBytes: 4194304 ***
*** loadedBytes: 8388608 ***
*** loadedBytes: 12582912 ***
*** loadedBytes: 16777216 ***
*** loadedBytes: 20971520 ***
*** loadedBytes: 25165824 ***
*** loadedBytes: 29360128 ***
*** loadedBytes: 33554432 ***
*** loadedBytes: 37748736 ***
*** loadedBytes: 41943040 ***
*** loadedBytes: 46137344 ***
*** loadedBytes: 50331648 ***
*** loadedBytes: 54525952 ***
*** loadedBytes: 58720256 ***
*** loadedBytes: 62914560 ***
*** loadedBytes: 67108864 ***
*** loadedBytes: 7[130](https://github.com/ezYakaEagle442/azure-spring-apps-petclinic-mic-srv/actions/runs/3322102903/jobs/5491343365#step:5:130)3168 ***
*** loadedBytes: 7[209](https://github.com/ezYakaEagle442/azure-spring-apps-petclinic-mic-srv/actions/runs/3322102903/jobs/5491343365#step:5:210)6613 ***
*** loadedBytes: 76290917 ***
*** loadedBytes: 80485[221](https://github.com/ezYakaEagle442/azure-spring-apps-petclinic-mic-srv/actions/runs/3322102903/jobs/5491343365#step:5:222) ***
*** loadedBytes: 84679525 ***
*** loadedBytes: 88873829 ***
CompletedUploadOf/home/runner/work/azure-spring-apps-petclinic-mic-srv/azure-spring-apps-petclinic-mic-srv/vets-service/asa-spring-petclinic-vets-service-2.6.6.jar
##[debug]list deployments response: []
Error: Action failed with error: deploymentName cannot be null or undefined.
##[debug]Node Action run completed with exit code 1
##[debug]Finishing: Deploy vets-service

Is this error related to this snippet ? : https://github.com/Azure/spring-apps-deploy/blob/main/src/operations/ActionParameters.ts#L69

ezYakaEagle442 commented 1 year ago

see https://github.com/Azure/spring-apps-deploy/blob/main/src/operations/ActionParameters.ts#L49 & https://github.com/Azure/spring-apps-deploy/blob/main/src/operations/ActionParameters.ts#L12

I doubt that would be a regression from GH Action Core