search

Azure / sql-action

🚀 Deploy changes to your SQL database easily with SQL projects or SQL scripts and sql-action for GitHub workflows
MIT License
103 stars 58 forks source link

Action does not work when connection string server name contains "tcp:" #143

Closed saasaTom closed 1 year ago

saasaTom commented 2 years ago

This action fails when the connection string contains a server name with "TCP" e.g. Server=tcp: MY_SERVER.

It fails when creating firewall rules due to filtering azure resources based off the Server value (including the text "tcp:". i.e. it looks for an azure resource with the name tcp: MY_SERVER

The error is thrown: Unable to get details of SQL server tcp: MY_SERVER. Sql server 'tcp: MY_SERVER' was not found in the subscription.

https://github.com/Azure/sql-action/blob/aacc6bc593bb80d5cfc0daf0c2ca523b9b133ddb/src/AzureSqlResourceManager.ts#L133

If no firewall is required, the connection works fine.

This should also be able to work using non-standard ports. i.e. Server=MY_SERVER,MY_PORT

github-actions[bot] commented 2 years ago

This issue is idle because it has been open for 14 days with no activity.

dzsquared commented 1 year ago

In version 2.1 we've added more debug logging- will you try it with debug logging enabled to see if more information is shown? https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging

github-actions[bot] commented 1 year ago

This issue is idle because it has been open for 14 days with no activity.