Azure / sql-action

🚀 Deploy changes to your SQL database easily with SQL projects or SQL scripts and sql-action for GitHub workflows
MIT License
103 stars 58 forks source link

Update go-sqlcmd to v0.12.0 #163

Closed shueybubbles closed 1 year ago

shueybubbles commented 1 year ago

This version fixes several issues with batch parsing and variables

zijchen commented 1 year ago

@shueybubbles Could you run npm run build and commit the main.js changes too? main.js is where the action actually runs out of so every time we change the ts files we need to build and update main.js

shueybubbles commented 1 year ago

I was hoping to complete this PR completely within the github UI and not pull down bits locally :-) Are the pre-reqs to build very complex to install?

shueybubbles commented 1 year ago

maybe consider moving the version number out of the typescript into some config file that main.js reads so it's resilient to minor changes

zijchen commented 1 year ago

I was hoping to complete this PR completely within the github UI and not pull down bits locally :-) Are the pre-reqs to build very complex to install?

You just need to have npm installed, then run npm install and npm run build from the root :)

zijchen commented 1 year ago

maybe consider moving the version number out of the typescript into some config file that main.js reads so it's resilient to minor changes

That's a good idea, I added #164 to track