search

Azure / sql-action

🚀 Deploy changes to your SQL database easily with SQL projects or SQL scripts and sql-action for GitHub workflows
MIT License
103 stars 58 forks source link

Removing /SourceFile: parameter from DriftReport arguments #167

Closed JoshFieldstad closed 1 year ago

JoshFieldstad commented 1 year ago

@microsoft-github-policy-service agree

JoshFieldstad commented 1 year ago

@zijchen FYI I am doing some testing on my side and after reviewing old PR's discovered that main.js needed to be recompiled when updating *.ts files. I ran

npm install
npm run build

and committed the result, if needed I am happy to revert this change or redo it using proper process. Thank you!

dzsquared commented 1 year ago

@JoshFieldstad - it looks like you will need to resolve the conflict on main.js (either revert the build or pull in the previous changes from the default branch)

JoshFieldstad commented 1 year ago

@dzsquared I reverted the change to main.js. What do you need from me on that main.js? Should I just leave it alone and let a pipeline or other process update it? Or is there something I should do?

Thanks!

dzsquared commented 1 year ago

@JoshFieldstad - usually you'd need to build main.js after having pulled in any recent changes from the default branch (it just so happens I merged to master this morning while you were working on this) - but I'm about to do a release and will open another PR with main.js built and some docs changes so no need for you to worry about it today :)

JoshFieldstad commented 1 year ago

@dzsquared Thank you sir!