Azure / sql-action

🚀 Deploy changes to your SQL database easily with SQL projects or SQL scripts and sql-action for GitHub workflows
MIT License
103 stars 58 forks source link

Failed to add firewall rule #205

Closed adobryn closed 4 months ago

adobryn commented 9 months ago

I'm trying to deploy to Azure DB from a runner VM within the same subscription.

For database this option "Allow public access from any Azure service within Azure to this server" is active but the GitHub Action still can't get past the firewall with the error message

Failed to add firewall rule. Unable to detect client IP Address.

Adding a public IP of the runner VM to firewall rules did not help. Also I can connect to the database using psql from the runner direct, and with az postgres flexible-server connect as well.

Is it possible to disable automatically adding new firewall rules in the action?

here is the code:

jobs:
  build:
    runs-on: [ self-hosted ]
    steps:
      - uses: actions/checkout@v3
      - uses: azure/sql-action@v2.2.1
        with:
          connection-string: ${{ secrets.AZURE_SQL_CONNECTION_STRING }}
          path: './project/projectsqlproj'
          action: 'publish'

Connection string is built like this:

Server=<dbname>.postgres.database.azure.com,<port number>;Initial Catalog=<name>; User ID=<username>; Password=<password>; Encrypt=True;TrustServerCertificate=False;Connection Timeout=30;
github-actions[bot] commented 9 months ago

This issue is idle because it has been open for 14 days with no activity.

benjamin-hodgson commented 6 months ago

+1 to this, I'd like a way to opt out of the automatic firewall behaviour. An option in the action yaml would suit me, something like this:

uses: azure/sql-action@v2.2.1
  with:
    connection-string: ...
    path: ...
    action: Publish
    configure-firewall: false

(My deployment works fine; I'm using OIDC to auth as a managed identity so I don't need the firewall config.)

benjamin-hodgson commented 6 months ago

Is this a dupe of #186 ?

github-actions[bot] commented 5 months ago

This issue is idle because it has been open for 14 days with no activity.