search

Azure / static-web-apps

Azure Static Web Apps. For bugs and feature requests, please create an issue in this repo. For community discussions, latest updates, kindly refer to the Discussions Tab. To know what's new in Static Web Apps, visit https://aka.ms/swa/ThisMonth
https://aka.ms/swa
MIT License
330 stars 56 forks source link

SWA deployment does not go through #1168

Open deven-gqc opened 1 year ago

deven-gqc commented 1 year ago

The workflow file was autogenerated by Azure. I have the dependencies correctly listed in the package.json as well. I'm not sure what is causing it to break. Can someone help with this? 

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

---End of Oryx build logs---
Oryx has failed to build the solution.

For further information, please visit the Azure Static Web Apps documentation at https://docs.microsoft.com/en-us/azure/static-web-apps/
If you believe this behavior is unexpected, please raise a GitHub issue at https://github.com/azure/static-web-apps/issues/
Exiting
thomasgauvin commented 1 year ago

Can you provide more logs about the error in question? It seems Oryx tried to build your project with Yarn but there was an error with running with Yarn. Can you also share you build command in your package.json? Are you able to share the repository in question?

deven-gqc commented 1 year ago

Here is my package.json

{
  "name": "@minimal/material-kit-react",
  "author": "minimals.cc",
  "licence": "MIT",
  "version": "1.3.0",
  "private": false,
  "engines": {
    "node": ">=16.0.0"
  },
  "scripts": {
    "start": "craco start",
    "build": "craco build",
    "test": "craco test",
    "eject": "react-scripts eject",
    "lint": "eslint --ext .js,.jsx ./src",
    "lint:fix": "eslint --fix --ext .js,.jsx ./src"
  },
  "eslintConfig": {
    "extends": [
      "react-app",
      "react-app/jest"
    ]
  },
  "babel": {
    "presets": [
      "@babel/preset-react"
    ]
  },
  "browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  },
  "dependencies": {
    "@craco/craco": "^6.4.3",
    "@emotion/react": "^11.8.1",
    "@emotion/styled": "^11.8.1",
    "@faker-js/faker": "^6.0.0-alpha.7",
    "@iconify/react": "^3.1.3",
    "@mui/icons-material": "^5.5.1",
    "@mui/lab": "^5.0.0-alpha.69",
    "@mui/material": "^5.4.2",
    "@mui/utils": "^5.4.2",
    "@testing-library/jest-dom": "^5.16.2",
    "apexcharts": "^3.33.1",
    "cesium": "^1.92.0",
    "change-case": "^4.1.2",
    "craco-cesium": "^1.2.0",
    "date-fns": "^2.28.0",
    "formik": "^2.2.9",
    "framer-motion": "^6.2.6",
    "history": "^5.2.0",
    "lodash": "^4.17.21",
    "numeral": "^2.0.6",
    "ol": "^7.2.2",
    "prop-types": "^15.8.1",
    "react": "^17.0.2",
    "react-apexcharts": "^1.3.9",
    "react-dom": "^17.0.2",
    "react-helmet-async": "^1.2.3",
    "react-router-dom": "^6.2.1",
    "react-scripts": "^5.0.0",
    "recharts": "^2.1.13",
    "resium": "^1.16.1",
    "simplebar": "^5.3.6",
    "simplebar-react": "^2.3.6",
    "web-vitals": "^2.1.4",
    "yup": "^0.32.11"
  },
  "devDependencies": {
    "@babel/core": "^7.17.5",
    "@babel/eslint-parser": "^7.17.0",
    "eslint": "^8.9.0",
    "eslint-config-airbnb": "^19.0.4",
    "eslint-config-prettier": "^8.4.0",
    "eslint-config-react-app": "^7.0.0",
    "eslint-plugin-flowtype": "^8.0.3",
    "eslint-plugin-import": "^2.25.4",
    "eslint-plugin-jsx-a11y": "^6.5.1",
    "eslint-plugin-prettier": "^4.0.0",
    "eslint-plugin-react": "^7.28.0",
    "eslint-plugin-react-hooks": "^4.3.0",
    "prettier": "^2.5.1"
  }
}

In issue #1166, the user suggested that I add CI=false in the build command. That fixed the issue. But in the past, I've developed similar SWAs without any problem. 

"build": "CI=false craco build",

cc @jacobgqc

thomasgauvin commented 1 year ago

Are you suggesting that CI=false fixes the issue?

It seems that CI=false may be React-related to prevent treating warnings as build errors as per https://github.com/facebook/create-react-app/issues/3657. This seems related to React rather than Static Web Apps. Can you verify if fixing the warnings fixes the build without needing CI=false?

If not, can you provide more logs about the error you are encountering?

deven-gqc commented 1 year ago

@thomasgauvin Previously I have deployed SWAs with these warnings and there was no problem without adding CI=false. I'm not sure what is causing it to break right now.