search

Azure / static-web-apps

Azure Static Web Apps. For bugs and feature requests, please create an issue in this repo. For community discussions, latest updates, kindly refer to the Discussions Tab. To know what's new in Static Web Apps, visit https://aka.ms/swa/ThisMonth
https://aka.ms/swa
MIT License
322 stars 54 forks source link

Add Federated Credentials support for GitHub Action (Azure/static-web-apps-deploy) #1304

Open MichaMican opened 10 months ago

MichaMican commented 10 months ago

Is your feature request related to a problem? Please describe. When using static-web-apps-deploy i cannot use the more secure federated credential for deployment authentication (as supported by deployment targets such as Azure App Service), but have to use azure_static_web_apps_api_token instead, which is less secure for obviouse reasons.

Describe the solution you'd like support the federated credentials via az login - similar to Azure/webapps-deploy

Describe alternatives you've considered I was considering using a workarround as described here: https://www.cloudwithchris.com/blog/using-oidc-github-actions-azure-swa/ however piping secret tokens into GITHUB_ENV is propably even less secure than storing them in the Github secrets store.

Additional context

thomasgauvin commented 10 months ago

Hi @MichaMican, I'm noting the feature request and we'll consider this in future plannings. Thanks for the feedback!