Azure / static-web-apps

Azure Static Web Apps. For bugs and feature requests, please create an issue in this repo. For community discussions, latest updates, kindly refer to the Discussions Tab. To know what's new in Static Web Apps, visit https://aka.ms/swa/ThisMonth
https://aka.ms/swa
MIT License
330 stars 57 forks source link

Support deployment using service principal instead of token #312

Open anthonychu opened 3 years ago

anthonychu commented 3 years ago

Support Azure Login GitHub Action in GitHub, or passing service principal credentials in Azure DevOps as well.

sinedied commented 3 years ago

Heavy 👍 on this one, as currently if you have any other Azure resource in addition to a SWA in your deployment workflow, it's way simpler to use the azure/login action and use its credentials instead of having to provide each one specific tokens.

kkgthb commented 1 year ago

👍. What @sinedied said.

rgrace-puck commented 1 month ago

This is badly needed. The deployment process for SWAs is unnecessarily complex because of the deployment token. Instead of passing in the service principal, you need to think about secret storage/retrieval/rotation in your pipelines.