Azure / terraform-azure-container-apps

A Terraform module to deploy a container app in Azure
https://github.com/Azure/terraform-azure-container-apps
35 stars 22 forks source link

Support for Authentication #14

Open configdump opened 12 months ago

configdump commented 12 months ago

Is there an existing issue for this?

Description

Support for auth_settings

New or Affected Resource(s)/Data Source(s)

azurerm_container_app

Potential Terraform Configuration

Similar setting as in azurerm_app_service(https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/app_service.html#auth_settings)

References

Similar setting as in azurerm_app_service(https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/app_service.html#auth_settings)

lonegunmanb commented 12 months ago

Hi @configdump thanks for opening this issue, I've checked the document but I cannot find configuration like auth_settings, would you please give us more details about your request? Thanks.

configdump commented 12 months ago

azurerm_container_app does not support authentication settings as of today. This is supported by az cli(https://learn.microsoft.com/en-us/cli/azure/containerapp/auth?view=azure-cli-latest) and also possible to set this up in the azure web portal. This feature request is to implement this feature in terraform.

implementation can be similar to the auth setting implementation in azurerm_app_service auth settings(https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/app_service.html#auth_settings)

lonegunmanb commented 11 months ago

Thanks for the clarification @configdump, it looks like we must implement this feature first in AzureRM provider, I've searched and found this issue. Please stay tuned and ping me here once the issue has been solved, thanks!

eksrha commented 8 months ago

Hi, what is the status on this topic? Would be really nice to have this.

lonegunmanb commented 8 months ago

@eksrha Thanks for asking, we can only bring this feature to this module once it has been supported in the AzureRM provider, if you like this idea, please add a thumb up here, thanks!