Better Front Door and Private Link integration due to module outputs

[icklsede]

Describe your changes

• add default_domain to outputs to determine internal loadbalancer IP for Private Link Service integration

• rename container_app_fqdn to container_app_uri and make container_app_fqdn a real FQDN The actual fqdn is in fact a URI, which can't be used as Front Door Origin, as it requires a bare FQDN.

Issue number

21

Checklist before requesting a review

• [x] The pr title can be used to describe what this pr did in CHANGELOG.md file
• [x] I have executed pre-commit on my machine
• [x] I have passed pr-check on my machine

Thanks for your cooperation!

[icklsede]

Unfortunately the PR-check failed because it is a module with a "dubious ownership" being in use :)

│ Error: Failed to download module
│
│   on main.tf line 27:
│   27: module "public_ip" {
│
│ Could not download module "public_ip" (main.tf:27) source code from
│ "git::https://github.com/lonegunmanb/terraform-lonegunmanb-public-ip?ref=v0.1.0":
│ error downloading
│ 'https://github.com/lonegunmanb/terraform-lonegunmanb-public-ip?ref=v0.1.0':
│ /usr/bin/git exited with 128: fatal: detected dubious ownership in
│ repository at '/src/examples/acr/.terraform/modules/public_ip'
│ To add an exception for this directory, call:
│
│       git config --global --add safe.directory
│ /src/examples/acr/.terraform/modules/public_ip
│ .

[lonegunmanb]

Unfortunately the PR-check failed because it is a module with a "dubious ownership" being in use :)

│ Error: Failed to download module
│
│   on main.tf line 27:
│   27: module "public_ip" {
│
│ Could not download module "public_ip" (main.tf:27) source code from
│ "git::https://github.com/lonegunmanb/terraform-lonegunmanb-public-ip?ref=v0.1.0":
│ error downloading
│ 'https://github.com/lonegunmanb/terraform-lonegunmanb-public-ip?ref=v0.1.0':
│ /usr/bin/git exited with 128: fatal: detected dubious ownership in
│ repository at '/src/examples/acr/.terraform/modules/public_ip'
│ To add an exception for this directory, call:
│
│       git config --global --add safe.directory
│ /src/examples/acr/.terraform/modules/public_ip
│ .

Thanks for your pr and apology for this inconvenience. I'll try to fix this issue, thanks for reporting it to us.

---

Terraform uses git to download Terraform module, so you saw this issue because the owner of '/src/examples/acr` is not the user you were using.

I'm thinking of adding git config --global --add safe.directory $(pwd) to the script, but I'm afraid maybe it is way to much for this issue.