search

Azure / terraform-azure-container-apps

A Terraform module to deploy a container app in Azure
https://github.com/Azure/terraform-azure-container-apps
35 stars 22 forks source link

Support for IP Security Restrictions Mode #29

Open davidkarlsen opened 8 months ago

davidkarlsen commented 8 months ago

Is there an existing issue for this?

Description

Support the "IP Security Restrictions Mode" feature of ingress where you can allow/deny given IP-ranges on the ingress.

New or Affected Resource(s)/Data Source(s)

N/A

Potential Terraform Configuration

Should only require new inputs to the terraform module, it will be backwards compatible because it is new parameters and won't affect existing mode.

References

https://learn.microsoft.com/en-us/azure/container-apps/ip-restrictions?pivots=azure-portal

update: seems to be needed in the the terraform resource as well: https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/container_app, tracked in https://github.com/hashicorp/terraform-provider-azurerm/issues/21774

lonegunmanb commented 8 months ago

Hi @davidkarlsen thanks for submitting this feature to this module, I'd like to track the (feature request in the provider)[https://github.com/hashicorp/terraform-provider-azurerm/issues/21774], once it has been solved then we can see what can do in this module.

davidkarlsen commented 8 months ago

I've added a PR to the provider.

davidkarlsen commented 6 months ago

@lonegunmanb It will come in the next provider release: https://github.com/hashicorp/terraform-provider-azurerm/pull/23870

davidkarlsen commented 6 months ago

It is GA now.