Azure / terraform-azure-container-apps

A Terraform module to deploy a container app in Azure

https://github.com/Azure/terraform-azure-container-apps

35 stars 22 forks source link

Support existing container apps environment #38

Closed davidkarlsen closed 7 months ago

davidkarlsen commented 7 months ago

Describe your changes

Support existing app service environment.

Issue number

37

Checklist before requesting a review

[X] The pr title can be used to describe what this pr did in CHANGELOG.md file
[ ] I have executed pre-commit on my machine
[x] I have passed pr-check on my machine

Thanks for your cooperation!

davidkarlsen commented 7 months ago

@lonegunmanb PTAL

davidkarlsen commented 7 months ago

@lonegunmanb done, can we let it run to see how the test works?

davidkarlsen commented 7 months ago

@lonegunmanb PTAL

davidkarlsen commented 7 months ago

@lonegunmanb I've rebased against current main - can we test the e2e's again?

lonegunmanb commented 7 months ago

@davidkarlsen Please wait for #40 and #39 then you're ok to rebase again, thanks!

lonegunmanb commented 7 months ago

Hi @davidkarlsen #39 has been merged so you're good to rebase with the latest main branch and try again, thanks for your patience!

davidkarlsen commented 7 months ago

@lonegunmanb done (PS: The branch os open for collab to merge into)

lonegunmanb commented 7 months ago

Hi @davidkarlsen I believe that the failed e2e test should have been fixed by #42 , would you please rebase your pr with the latest main branch and try again? Sorry for your inconvenience.

davidkarlsen commented 7 months ago

@lonegunmanb done