Azure / terraform-azure-container-apps

A Terraform module to deploy a container app in Azure

https://github.com/Azure/terraform-azure-container-apps

37 stars 24 forks source link

support workload profiles #45

Closed davidkarlsen closed 9 months ago

davidkarlsen commented 9 months ago

Describe your changes

Support workload profiles, this is new in https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.85.0 This will also avoid continuous drift, else you'll get:

      - workload_profile_name         = "Consumption" -> null

Issue number

000

Checklist before requesting a review

[X] The pr title can be used to describe what this pr did in CHANGELOG.md file
[ ] I have executed pre-commit on my machine
[X] I have passed pr-check on my machine

Thanks for your cooperation!

lonegunmanb commented 9 months ago

Hi @davidkarlsen thanks for opening this pr! I've tried v3.85.0 provider with startup example, and I found that there's no configuration drift on workload_profile_name, it always be empty string. According to the schema, this new attribute has no default value.

davidkarlsen commented 9 months ago

Hi @davidkarlsen thanks for opening this pr! I've tried v3.85.0 provider with startup example, and I found that there's no configuration drift on workload_profile_name, it always be empty string. According to the schema, this new attribute has no default value.

Hm, probably there were some changes over time in the provider which messed it up. Let me taint the resource and re-create to test something,

davidkarlsen commented 9 months ago

@lonegunmanb thanks - can you create tags (and proper gh releases would be good too, as they give insights in what changes went in etc)

lonegunmanb commented 9 months ago

@davidkarlsen We've just released a tag version. I'd like to add another feature support for this module then release our next tag.

davidkarlsen commented 9 months ago

@lonegunmanb okidok, but releasing often and little is good as it gets out the features and helps adoption IMHO. BTW: https://github.com/marvinpinto/action-automatic-releases can be used to automate creation of gh-releases when tagging.

lonegunmanb commented 9 months ago

Thanks @davidkarlsen for your advice, we didn't choose automatic release due to certain considerations. We treat breaking changes very seriously, so we'd like to manage our release process manually, and keep all breaking changes in one major version upgrade.

davidkarlsen commented 9 months ago

syre - and that's fine - it's just that: https://github.com/Azure/terraform-azure-container-apps/releases is off vs https://github.com/Azure/terraform-azure-container-apps/tags