Support for key vault references

epa095 commented 5 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Description

Its possible to have secrets based on a key-vault reference, https://learn.microsoft.com/en-us/azure/container-apps/manage-secrets?tabs=arm-template#reference-secret-from-key-vault

But can it be done with this module?

I tried the following, but then it complained that I need "value". If I put the keyvault URI in the value, then the URL itself becomes the secret.


  container_app_secrets = {
    nginx= [
      {
        name        = "secret"
        keyVaultUrl = "https://somethingvault.azure.net/secrets/thesecret"
        identity    = "system"
      }
    ]
  }

New or Affected Resource(s)/Data Source(s)

N/A

Potential Terraform Configuration

No response

References

https://learn.microsoft.com/en-us/azure/container-apps/manage-secrets?tabs=arm-template#reference-secret-from-key-vault

lonegunmanb commented 5 months ago

Thanks @epa095 for opening this pr! I've checked the provider's schema, we need add KeyVaultUrl support there first.

I'll open a pr to the provider's repo.

matthew-patrick commented 3 months ago

It looks like it was implemented into tf provider. Is there an anticipated timelike for when this can be implemented into the module as well as a documentation update?

Azure / terraform-azure-container-apps