Add support for secrets from KV

Azure / terraform-azure-container-apps

A Terraform module to deploy a container app in Azure

https://github.com/Azure/terraform-azure-container-apps

35 stars 22 forks source link

Add support for secrets from KV #55

Open davidkarlsen opened 2 months ago

davidkarlsen commented 2 months ago

Describe your changes

Adds support for referencing secrets from key-vault.

Issue number

Fixes #52

Checklist before requesting a review

[X] The pr title can be used to describe what this pr did in CHANGELOG.md file
[X] I have executed pre-commit on my machine
[] I have passed pr-check on my machine

Thanks for your cooperation!

davidkarlsen commented 2 months ago

@lonegunmanb PTAL. Also be aware of https://github.com/microsoft/azure-container-apps/issues/1159 but this seems to be a service problem.

lonegunmanb commented 1 month ago

Hi @davidkarlsen thanks for opening this pr! I was too busy these days so I failed to noticed this pr in time. According to the CHANGELOG this feature was introduced in v3.98.0. Would you please upgrade version to >= v3.98.0, < 4.0, then run make tffmt to solve the format issue, and try again? Thanks!