Azure / terraform-azure-container-apps

A Terraform module to deploy a container app in Azure
https://github.com/Azure/terraform-azure-container-apps
37 stars 24 forks source link

Add support for httpMaxRequestSize in dapr configuration #56

Closed rodyvansambeek closed 4 months ago

rodyvansambeek commented 4 months ago

Is there an existing issue for this?

Description

I am using the settings at the Dapr configuration like:

See: https://learn.microsoft.com/en-us/azure/templates/microsoft.app/containerapps?pivots=deployment-language-terraform

You can also set these options using the Azure Portal, but there seems to be no option using the terraform definitions.

I tried:

resource "azurerm_container_app" "example" {
  name                         = "example"
  container_app_environment_id = ...
  resource_group_name          = ...
  revision_mode                = "Single"
  dapr {
    app_id = "ca-cn-import"
    http_max_request_size = 16000000
  }

but that didn't work unfortunately

New or Affected Resource(s)/Data Source(s)

azurerm_container_app

Potential Terraform Configuration

resource "azurerm_container_app" "example" {
  name                         = "example"
  container_app_environment_id = ...
  resource_group_name          = ...
  revision_mode                = "Single"
  dapr {
    app_id = "ca-cn-import"
    http_max_request_size = 16000000   <------
  }

References

No response

lonegunmanb commented 4 months ago

Hello @rodyvansambeek thanks for opening this issue to us! This request looks like a request to azurerm provider, so would you please open an issue there? This module couldn't support this feature unless the provider already supported it. Thanks for your understanding!

rodyvansambeek commented 4 months ago

@lonegunmanb Ah, I see, you are right. I will open up a new issue there to see if we can manage to get it added in the azurerm provider. Thanks!