search

Azure / terraform-azurerm-aci-devops-agent

Terraform Module to deploy a Azure DevOps self-hosted agents on Azure Container Instance
MIT License
94 stars 66 forks source link

Terraform breaks #31

Closed vimal-vijayan closed 2 years ago

vimal-vijayan commented 2 years ago

Terraform breaks for os_type variable, expect "Linux and Windows" instead of "linux and windows". Ip address type should "Private & Public" instead of "private & public"

  1. ip_address_type = var.enable_vnet_integration ? "private" : "public"
  2. os_type = "linux"
  3. ip_address_type = var.enable_vnet_integration ? "private" : "public"
  4. os_type = "windows"
AmudaPalani commented 2 years ago

Running into same error

TrollProxy commented 2 years ago

Created #33 to fix this, lets see if someone reviews it!

jcorioland commented 2 years ago

Update: the update has already been merged (https://github.com/Azure/terraform-azurerm-aci-devops-agent/pull/32), but new release was not done. I just did it and it fixes the issue for me to switch to version 0.9.3.

clbarrett commented 2 years ago

Version 0.9.3 fixed both these issues for me. Thanks!

jcorioland commented 2 years ago

thanks for the quick feedback @clbarret. and thank you for the contribution @vimal-vijayan!

I am now closing this issue.

vimal-vijayan commented 2 years ago

Well done!

Thanks & Regards, Vimal

On Thu, 16 Jun, 2022, 1:40 pm Julien Corioland, @.***> wrote:

thanks for the quick feedback @clbarret https://github.com/clbarret. and thank you for the contribution @vimal-vijayan https://github.com/vimal-vijayan!

I am now closing this issue.

— Reply to this email directly, view it on GitHub https://github.com/Azure/terraform-azurerm-aci-devops-agent/issues/31#issuecomment-1157560587, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQA6C4DFY74T5NIBNA2EHTVPMHA7ANCNFSM5TLTA7ZA . You are receiving this because you were mentioned.Message ID: @.***>