search

Azure / terraform-azurerm-aci-devops-agent

Terraform Module to deploy a Azure DevOps self-hosted agents on Azure Container Instance
MIT License
94 stars 65 forks source link

allow modification of container port #8

Closed kathryn-explorable closed 3 years ago

kathryn-explorable commented 4 years ago

Thanks for this useful module! It would be nice to allow modification of the container port. Flask apps require 5000 by default. Or 443 would be useful for other applications.

ghost commented 4 years ago

CLA assistant check
All CLA requirements met.

jcorioland commented 3 years ago

Hi @kathryn-explorable! thanks for the PR (and sorry for the delay). Why exactly you need to run flask inside the Azure DevOps agent image?

kathryn-explorable commented 3 years ago

Hi @jcorioland the plan was to create a serverless Flask API. Python has many data science libraries, and it's usually what I use for bioinformatics applications. If you think there's a better approach for this sort of thing, I'm happy to get advice!

jcorioland commented 3 years ago

Hi @kathryn-explorable, thanks for the update, but I am not sure to understand exactly what you are trying to achieve. Why running the Flask API into the same container than the Azure DevOps agent? Have you thought to run it into a dedicated container instance? Something like that -> https://medium.com/@alexjsanchez/creating-and-deploying-a-flask-app-with-docker-on-azure-in-5-easy-9f7aa7a12145 ?

jcorioland commented 3 years ago

@kathryn-explorable have you been able to solve your issue? Should we keep this PR open?

jcorioland commented 3 years ago

Closing this PR as it was not active since June. Feel free to reopen @kathryn-explorable and provide more details, if needed.