Azure / terraform-azurerm-aks

Terraform Module for deploying an AKS cluster

MIT License

360 stars 468 forks source link

Add `v4` sub-folder so this module could run with AzureRM provider both `v3` and `v4`. #594

Open lonegunmanb opened 2 months ago

lonegunmanb commented 2 months ago

Describe your changes

This pr added v4 sub-folder and referenced all .tf files via symbolic link, and patch resources by adding Terraform override files, so the users who'd like to use AzureRM v4 could do it by setting module's source to Azure/aks/azurerm//v4.

Issue number

000

Checklist before requesting a review

[ ] The pr title can be used to describe what this pr did in CHANGELOG.md file
[ ] I have executed pre-commit on my machine
[ ] I have passed pr-check on my machine

Thanks for your cooperation!

Glaaj commented 1 week ago

Is this one on the radar? I'm waiting for this module to be ready for V4 so that I can leverage the options V4 has to offer like service endpoints on a vnet..

johnknutsonhc commented 1 week ago

Anything we can do to help move this along? We'd like to update our azurerm provider to 4.x

philippeckelintive commented 3 days ago

The failed action clearly states the problem:

end to end / acc-tests The job running on runner GitHub Actions 784 has exceeded the maximum execution time of 360 minutes.

6 hours is GitHub's usage limit.

I'd guess splitting up the test into smaller chunks should solve this.