Azure / terraform-azurerm-avm-ptn-hubnetworking

Azure Verified Module for the Multi-hub networking pattern
https://registry.terraform.io/modules/Azure/avm-ptn-hubnetworking
MIT License
3 stars 3 forks source link

bug: deprecated variable `disable_bgp_route_propagation` on `azurerm_route_table` #75

Open jaredfholgate opened 4 days ago

jaredfholgate commented 4 days ago

Is there an existing issue for this?

Greenfield/Brownfield provisioning

greenfield

Terraform Version

latest

Module Version

latest

AzureRM Provider Version

3.x

Affected Resource(s)/Data Source(s)

azurerm_route_table

Terraform Configuration Files

It is the default for this module

tfvars variables values

Not relevant

Debug Output/Panic Output

Warning: Argument is deprecated
│
│   with module.hub_and_spoke_vnet[0].module.hub_routing["primary"].azurerm_route_table.this,
│   on .terraform\modules\hub_and_spoke_vnet.hub_routing\main.tf line 6, in resource "azurerm_route_table" "this":
│    6:   disable_bgp_route_propagation = var.disable_bgp_route_propagation
│
│ The property `disable_bgp_route_propagation` has been superseded by the property `bgp_route_propagation_enabled` and will be removed in v4.0 of the AzureRM Provider.

Expected Behaviour

No warning is shown

Actual Behaviour

Warning is shown

Steps to Reproduce

No response

Important Factoids

No response

References

No response

azure-lm commented 4 days ago

I believe we need to get a fix made here: https://github.com/Azure/terraform-azurerm-avm-res-network-routetable/blob/main/main.tf#L6

jaredfholgate commented 4 days ago

I believe we need to get a fix made here: https://github.com/Azure/terraform-azurerm-avm-res-network-routetable/blob/main/main.tf#L6

Yep that is right. This is not urgent, just flagging it.