Azure / terraform-azurerm-avm-ptn-hubnetworking

Azure Verified Module for the Multi-hub networking pattern
https://registry.terraform.io/modules/Azure/avm-ptn-hubnetworking
MIT License
3 stars 3 forks source link

Support for one hub network to have multiple firewall custom public IP addresses #76

Open VeronicaSea opened 2 weeks ago

VeronicaSea commented 2 weeks ago

Is there an existing issue for this?

Description

Support for one hub network to have multiple firewall custom public IP addresses.

Right now, this module only supports one hub network mapping to one default public IP, not support custom public IP addresses.

New or Affected Resource(s)/Data Source(s)

avm-ptn-hubnetworking

Potential Terraform Configuration

This could be configured in the following code block:

module "hub_firewalls" {
  for_each = local.firewalls
  source   = "Azure/avm-res-network-azurefirewall/azurerm"
  version  = "0.2.2"

  firewall_sku_name   = each.value.sku_name
  firewall_sku_tier   = each.value.sku_tier
  location            = var.hub_virtual_networks[each.key].location
  name                = each.value.name
  resource_group_name = var.hub_virtual_networks[each.key].resource_group_name
  firewall_ip_configuration = [{
    name                 = each.value.default_ip_configuration.name

    ### Support multiple custom public IP addresses as needed.
    public_ip_address_id = module.fw_default_ips[each.key].public_ip_id 

    subnet_id            = azurerm_subnet.fw_subnet[each.key].id
  }
]

References

https://github.com/Azure/terraform-azurerm-avm-res-network-azurefirewall

microsoft-github-policy-service[bot] commented 6 days ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-terraform) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!