Azure / terraform-azurerm-avm-ptn-virtualwan

The Azure Verified Module for the Virtual WAN Pattern
https://registry.terraform.io/modules/Azure/avm-ptn-virtualwan/azurerm/latest
MIT License
8 stars 15 forks source link

[AVM Module Issue]: Connection details not included in outputs #114

Open JWilkinsonMB opened 1 week ago

JWilkinsonMB commented 1 week ago

Check for previous/existing GitHub issues

Issue Type?

Bug

(Optional) Module Version

v0.5.0

(Optional) Correlation Id

No response

Description

Connection details aren't exported as outputs for Virtual Network, VPN site & ExpressRoute.

azurerm_vpn_gateway_connection azurerm_express_route_connection azurerm_virtual_hub_connection

This makes it more difficult to build dependencies based on these connections, e.g. BGP Peering if done outside of the module whilst it's not currently supported natively (see https://github.com/Azure/terraform-azurerm-avm-ptn-virtualwan/issues/113)

Can be worked around by constructing the resource IDs based on the inputs & setting an explicit dependency on the entire module rather than letting Terraform work out the implicit dependencies, but would be cleaner if the resources could be included in outputs.

microsoft-github-policy-service[bot] commented 1 week ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the TF Issue Triage documentation.