search

Azure / terraform-azurerm-avm-ptn-virtualwan

MIT License
5 stars 11 forks source link

Bug fix: Resource Group and VWAN creation results in race condition #13

Closed khushal08 closed 7 months ago

jaredfholgate commented 9 months ago

Apologies, I see now that the creation of a resource group is optional. I will update to provide a suggested approach.

khushal08 commented 9 months ago

@jaredfholgate Overall changes look good. Can you add "create_resource_group" in all the examples? Lokks like you have only added in the basic test folder. Also would you like to comment on https://github.com/Azure/terraform-azurerm-avm-ptn-virtualwan/pull/13/files#r1391684150?

jaredfholgate commented 9 months ago

@jaredfholgate Overall changes look good. Can you add "create_resource_group" in all the examples? Lokks like you have only added in the basic test folder. Also would you like to comment on https://github.com/Azure/terraform-azurerm-avm-ptn-virtualwan/pull/13/files#r1391684150?

Done. Thanks